Fix: Browser <title> tag is not rendered when overriding content_title in custom templates#7619
Merged
Merged
Conversation
…e in custom templates When creating a custom template that extends @EasyAdmin/page/content.html.twig and overriding the content_title block (as recommended by the deprecation notices), the browser's <title> tag remains empty.
Collaborator
|
Thanks for fixing this bug @matixxd1999. |
Contributor
|
This fix looks weird to me. On the same template we have: {% block page_title %}{{ block('content_title') }}{% endblock %}
{% block content_title %}{{ block('page_title') }}{% endblock %} |
Contributor
Author
|
Hey @Seb33300, I agree it looks like a circular dependency at first glance! However, it's a necessary "Twig bridge" to maintain backward compatibility without breaking the layout. Because Twig evaluates the final overridden block from the child template first, it doesn't cause an infinite loop. It just links both blocks depending on what the user overrides:
Without this, the previously empty |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a custom template that extends @EasyAdmin/page/content.html.twig and overriding the content_title block (as recommended by the deprecation notices), the browser's <title> tag remains empty.